drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] amansinha100 commented on a change in pull request #1738: DRILL-7062: Initial implementation of run-time row-group pruning
Date Mon, 08 Apr 2019 02:31:52 GMT
amansinha100 commented on a change in pull request #1738: DRILL-7062: Initial implementation
of run-time row-group pruning
URL: https://github.com/apache/drill/pull/1738#discussion_r272858430
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/metadata/Metadata.java
 ##########
 @@ -127,9 +127,21 @@ public static void createMeta(FileSystem fs, Path path, ParquetReaderConfig
read
    *
    * @return parquet table metadata
    */
-  public static ParquetTableMetadata_v3 getParquetTableMetadata(FileSystem fs, String path,
ParquetReaderConfig readerConfig) throws IOException {
+  public static ParquetTableMetadata_v3 getParquetTableMetadata(ParquetMetadata footer, FileSystem
fs, String path, ParquetReaderConfig readerConfig) throws IOException {
     Metadata metadata = new Metadata(readerConfig);
-    return metadata.getParquetTableMetadata(path, fs);
+    return metadata.getParquetTableMetadata(path, fs, footer);
+  }
+
+  /**
+   *  When the footer is not yet available (it would be read)
 
 Review comment:
   The comment seems incomplete..it should mention something about what the `getParquetTableMetadata()`
does and add the footer information as a side-note, not the main description.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message