From dev-return-46910-apmail-drill-dev-archive=drill.apache.org@drill.apache.org Sun Apr 7 13:03:23 2019 Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 1DD9F188EC for ; Sun, 7 Apr 2019 13:03:23 +0000 (UTC) Received: (qmail 5964 invoked by uid 500); 7 Apr 2019 12:43:44 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 5572 invoked by uid 500); 7 Apr 2019 12:43:44 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 5355 invoked by uid 99); 7 Apr 2019 12:43:43 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 07 Apr 2019 12:43:43 +0000 From: GitBox To: dev@drill.apache.org Subject: [GitHub] [drill] arina-ielchiieva commented on a change in pull request #1726: DRILL-7143: Support default value for empty columns Message-ID: <155464220102.25707.12475143249596981326.gitbox@gitbox.apache.org> Date: Sun, 07 Apr 2019 13:03:21 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit arina-ielchiieva commented on a change in pull request #1726: DRILL-7143: Support default value for empty columns URL: https://github.com/apache/drill/pull/1726#discussion_r272833439 ########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/TextFormatPlugin.java ########## @@ -237,6 +238,12 @@ protected FileScanBuilder frameworkBuilder( builder.setOutputSchema(scan.getSchema()); + // CSV maps blank columns to to nulls (for nullable non-string columns), Review comment: Please remove extra `to`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services