drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] paul-rogers commented on pull request #2074: DRILL-7728: SPI framework
Date Tue, 02 Jun 2020 19:11:04 GMT

paul-rogers commented on pull request #2074:
URL: https://github.com/apache/drill/pull/2074#issuecomment-637750638


   @sanel, thanks for the comments. Yes, there should be handling of the corner cases you
mentioned. If there are two jars with the same code (different versions), they will get loaded
as different plugins. That is one advantage of class loader isolation (which is still to be
added.) It is a user question if they want "foo.1.2.3" and "foo.1.3.1" to both be available
as plugins.
   
   The multi-Drillbit issue is for the future. This PR  just adds the base framework; nothing
uses it yet.
   
   That said, the goal of this work is to provide an easier way to create and manage plugins.
Given the desire for a 1.18 release, and the lull in contributors, maybe now is not the best
time for such a major change. Let's sit on the PR and see what the future holds.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message