drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] cgivre commented on a change in pull request #2069: DRILL-7723 - Add Excel Metadata as Implicit Fields
Date Fri, 12 Jun 2020 15:48:23 GMT

cgivre commented on a change in pull request #2069:
URL: https://github.com/apache/drill/pull/2069#discussion_r439499328



##########
File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java
##########
@@ -56,60 +61,70 @@
   private static final Logger logger = org.slf4j.LoggerFactory.getLogger(ExcelBatchReader.class);
 
   private static final String SAFE_WILDCARD = "_$";
-
   private static final String SAFE_SEPARATOR = "_";
-
   private static final String PARSER_WILDCARD = ".*";
-
   private static final String HEADER_NEW_LINE_REPLACEMENT = "__";
-
   private static final String MISSING_FIELD_NAME_HEADER = "field_";
 
-  private static final int ROW_CACHE_SIZE = 100;
+  private enum IMPLICIT_STRING_COLUMNS {
+    _category,

Review comment:
       @vvysotskyi 
   To clarify, the fields here are metadata fields and I wanted to make sure that they do
not conflict with fields that might actually be in the users' data.  It is a fairly standard
practice to begin metadata fields with an `_`.  I've seen this done in many other platforms.
 
   
   In any event, how would you like me to proceed with this?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message