drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] sanel commented on a change in pull request #2088: DRILL-7750: Drill fails to read KeyStore password from Credential provider
Date Thu, 18 Jun 2020 12:10:02 GMT

sanel commented on a change in pull request #2088:
URL: https://github.com/apache/drill/pull/2088#discussion_r442177833



##########
File path: exec/java-exec/src/main/java/org/apache/drill/exec/ssl/SSLConfigServer.java
##########
@@ -226,11 +230,26 @@ private String getHadoopConfigParam(String name) {
     return value;
   }
 
-  private String resolveHadoopPropertyName(String nameTemplate, Mode mode) {
-    return MessageFormat.format(nameTemplate, mode.toString().toLowerCase());
-  }
+  private String getPasswordConfigParam(String name, String hadoopName) {

Review comment:
       Looks good :+1: 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message