drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] cgivre commented on pull request #2084: [WIP] DRILL-7745: Add storage plugin for IPFS
Date Thu, 18 Jun 2020 15:45:07 GMT

cgivre commented on pull request #2084:
URL: https://github.com/apache/drill/pull/2084#issuecomment-646111328


   @dbw9580 
   Why don't you break out CSV and the writer support as separate PRs.  Then we can get this
in, and work on those for the next release. 
   
   I've never done a writer, but I can assist with the CSV reader.   Take a look here:
   https://github.com/apache/drill/blob/master/contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpCSVBatchReader.java
   
   The HTTP storage plugin can read either `JSON` or `CSV`.  I attempted to use Drill's built
in CSV reader but I would have had to do a lot of work on the CSV reader to get it to work...
So... just used this simple version.  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message