drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] vvysotskyi commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS
Date Tue, 23 Jun 2020 08:29:59 GMT

vvysotskyi commented on a change in pull request #2084:
URL: https://github.com/apache/drill/pull/2084#discussion_r444052723



##########
File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSContext.java
##########
@@ -0,0 +1,95 @@
+/*
+ * Copyright (c) 2018-2020 Bowen Ding, Yuedong Xu, Liang Wang

Review comment:
       Neither current code nor docs don't have any mention about their authors, and I don't
think that it should be changed. As I mentioned above, it would be hard to keep a list of
**all** contributors for the specific code part. Git history allows to see specific contribution,
but just putting the author name to the code doesn't show anything related to the changes.
What would we do with authorship if the plugin will be rewritten in the future from scratch,
or significantly refactored, so it would differ significantly from its initial version? Using
just git history solves this issue, and I don't think that we should introduce more complexity.





----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message