drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] cgivre commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS
Date Tue, 23 Jun 2020 13:46:19 GMT

cgivre commented on a change in pull request #2084:
URL: https://github.com/apache/drill/pull/2084#discussion_r444236047



##########
File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSContext.java
##########
@@ -0,0 +1,95 @@
+/*
+ * Copyright (c) 2018-2020 Bowen Ding, Yuedong Xu, Liang Wang

Review comment:
       @dbw9580
   Are you just looking for a permanent link for attribution?  If you go with the aforementioned
approach, the issue is that we squash all commits into one commit prior to committing.  I
suspect that your name change would be lost in the shuffle. 
   
   Another option might be to put your names in both the JIRA and the pull request description.
 You could also include a comment somewhere in the code pointing to the JIRA.  In publications
I would assume you could then refer to the JIRA or pull request link.
   
   @vvysotskyi would that be acceptable?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message