drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] sanel commented on a change in pull request #2093: DRILL-7764: Cleanup warning messages in GuavaPatcher class
Date Fri, 03 Jul 2020 10:37:23 GMT

sanel commented on a change in pull request #2093:
URL: https://github.com/apache/drill/pull/2093#discussion_r449513573



##########
File path: common/src/main/java/org/apache/drill/common/util/GuavaPatcher.java
##########
@@ -73,7 +73,8 @@ private static void patchStopwatch() {
 
       logger.info("Google's Stopwatch patched for old HBase Guava version.");
     } catch (Exception e) {
-      logger.warn("Unable to patch Guava classes.", e);
+      logger.warn("Unable to patch Guava classes: {}", e.getMessage());

Review comment:
       These calls can be wrapped in a small static function




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message