drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] sanel commented on a change in pull request #2092: DRILL-7763: Add Limit Pushdown to File Based Storage Plugins
Date Fri, 03 Jul 2020 10:46:05 GMT

sanel commented on a change in pull request #2092:
URL: https://github.com/apache/drill/pull/2092#discussion_r449517251



##########
File path: contrib/format-esri/src/main/java/org/apache/drill/exec/store/esri/ShpBatchReader.java
##########
@@ -180,6 +182,10 @@ private String byteArrayToString(byte[] in) {
   }
 
   private void processShapefileSet(RowSetLoader rowWriter, final int gid, final Geometry
geom, final Object[] dbfRow) {
+    if (maxRecords > 0 && rowWriter.rowCount() >= maxRecords) {

Review comment:
       Same code happens to be used in multiple places? Maybe static function will make it
clearer




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message