drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] cgivre commented on a change in pull request #2092: DRILL-7763: Add Limit Pushdown to File Based Storage Plugins
Date Wed, 08 Jul 2020 15:48:18 GMT

cgivre commented on a change in pull request #2092:
URL: https://github.com/apache/drill/pull/2092#discussion_r451646671



##########
File path: contrib/format-spss/src/test/java/org/apache/drill/exec/store/spss/TestSpssReader.java
##########
@@ -108,7 +108,7 @@ public void testStarQuery() throws Exception {
 
   @Test
   public void testExplicitQuery() throws Exception {
-    String sql = "SELECT ID, Urban, Urban_value FROM dfs.`spss/testdata.sav` WHERE d16=4";
+    String sql = "SELECT ID, Urban, Urban_value FROM dfs.`spss/testdata.sav` WHERE d16=4
LIMIT 5";

Review comment:
       @KazydubB 
   I'll add additional unit tests this weekend.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message