drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] cgivre commented on pull request #2084: DRILL-7745: Add storage plugin for IPFS
Date Fri, 10 Jul 2020 04:44:59 GMT

cgivre commented on pull request #2084:
URL: https://github.com/apache/drill/pull/2084#issuecomment-656479289


   > > Cleaning up the PR. I was thinking about the unit tests and it might be good
to include unit tests using Mockito to mock up some of the various components. That way we
can test at least some of this without the IPFS daemon. I can post an example if you'd like.
   > 
   > Would appreciate that.
   
   Take a look here for an example:
   
   https://github.com/apache/drill/blob/5900cdfaae20e216d4b87795bd2efc8199e648e6/contrib/storage-elastic/src/test/java/org/apache/drill/exec/store/elasticsearch/ElasticSearchGroupScanTest.java#L42-L96
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message