drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] nielsbasjes commented on pull request #2112: DRILL-7534: Convert HTTPD Format Plugin to EVF
Date Fri, 13 Nov 2020 14:45:00 GMT

nielsbasjes commented on pull request #2112:
URL: https://github.com/apache/drill/pull/2112#issuecomment-726803738


   I was thinking about the concept of the extensions to match the files. 
   When I look at my own access log files they are named something like `access_log` or `access_log-20201108`
and as such the idea of the extension does not work for me.
   
   I see that this is the way it is configured and used in the `EasyFormatPlugin`  `EasyFormatConfig`
.
   Looking deeper into the code I see that this list of extensions is used to create a `BasicFormatMatcher`
which then internally stores them as a list of `Pattern`s ... and it also has a constructor
that allows you to just specify these patterns.
   
   To me it would make a lot more sense that the `extensions` is replaced by `fileNamePatterns`.
   I'm totally fine with having the same default as it is now:  `*\.httpd`
   
   What do you think @cgivre ?
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message