drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] cgivre commented on pull request #2112: DRILL-7534: Convert HTTPD Format Plugin to EVF
Date Sun, 15 Nov 2020 16:53:24 GMT

cgivre commented on pull request #2112:
URL: https://github.com/apache/drill/pull/2112#issuecomment-727600766


   Hi @nielsbasjes 
   I think we're ready for the next round of review.  I do have a few questions for you:
   
   1. Is there a dissector for user agent strings?  I'd like to include that if possible so
that the user doesn't have to call UDFs to get user agent info.  However, this could cause
performance degradation, so if this is possible, I might make a config option to disable it
by default. 
   
   2.  I made some modifications to use the default timestamp parser instead of asking this
from the user.  (The user can still specify one, but if the field is `null` then it doesn't
get passed.). In doing so, I ran into another issue.  If you look at the setter below, I still
need to get an actual timestamp so that I can send the timestamp to the Drill `ScalarWriter`.
 Unfortunately, the parser is sending a `String` and hence, I still need a format string.
Is there a way to either: 
   a.  Get the format string from the parser? Or
   b.  Get the parser to return a timestamp of some sort so that I don't have to do the conversion?
   
   Thanks!
   
   https://github.com/apache/drill/blob/a53402eb9cc3c602aa55565e95ce01ef9b917249/contrib/format-httpd/src/main/java/org/apache/drill/exec/store/httpd/HttpdLogRecord.java#L120-L140
   
   Here's where the results are being mapped to the setters:
   
   https://github.com/apache/drill/blob/a53402eb9cc3c602aa55565e95ce01ef9b917249/contrib/format-httpd/src/main/java/org/apache/drill/exec/store/httpd/HttpdLogRecord.java#L321-L326
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message