drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] nielsbasjes commented on pull request #2112: DRILL-7534: Convert HTTPD Format Plugin to EVF
Date Mon, 16 Nov 2020 09:08:21 GMT

nielsbasjes commented on pull request #2112:
URL: https://github.com/apache/drill/pull/2112#issuecomment-727842570


   Regarding 1: There is a LogParser Dissector (UserAgentDissector) that uses Yauaa: https://yauaa.basjes.nl/UDF-LogParser.html
. 
   You can of course enable/disable this with a setting. I think you can also simply enable
it by default as the parsing is automatically optimized out if you do not ask for the parse
result fields. So if you only select certain fields then the runtime performance difference
should be 0.
   
   Regarding 2: In the LogParser there is already code to further parse the timestamp format
into usable parts. For this situation I think the best way to obtain the timestamp in a usable
generic form is by retrieving (for example) the `TIME.EPOCH:request.receive.time.epoch` as
this is a `long` that is the number of milliseconds since 1970-01-01 which would simplify
the code to having a setter `public void setTimestamp(long value)` which can then simply do
something like `Instant.ofEpochMilli(something)`. This way you are leveraging the parsing
capabilities I've already built into the system.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message