drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] cgivre commented on pull request #2112: DRILL-7534: Convert HTTPD Format Plugin to EVF
Date Mon, 16 Nov 2020 15:37:43 GMT

cgivre commented on pull request #2112:
URL: https://github.com/apache/drill/pull/2112#issuecomment-728139758

   Thanks for answering the questions.  I now have a few more...
   1.  The is the field `request_referer_time` formatted exactly as it comes out of the log
file or is this something that your parser reformats?
   2.  Does your parser consistently return the date fields in the format `yyyy-mm-dd`, or
are these also at the mercy of the underlying format?  Are time fields also guaranteed to
be returned in the format `hh:mm:ss`?
   3.  I also experimented with adding the UA dissector to the parser.  It did have a significant
speed cost however.  I think the issue is around the `dummy` parser that is created to build
the schema.  For some perspective, most of my unit tests were completing in under 1 second
without the UA dissector and around 3 seconds with it. 
   I'm going to finish the date fields first, then I will do additional experiments on the
UA dissector. 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:

View raw message