drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] rymarm opened a new pull request #2117: DRILL-7812: updated hashCode function for MaterializedField
Date Thu, 26 Nov 2020 11:52:37 GMT

rymarm opened a new pull request #2117:
URL: https://github.com/apache/drill/pull/2117


   # [DRILL-7801](https://issues.apache.org/jira/browse/DRILL-7812): Broken equals/hashcode
contract 
   
   ## Description
   MaterializedField had broken hashCode/equals contract:
   
   > If two objects are equal according to the equals(Object) method, then calling the
hashCode method on each of the two objects must produce the same integer result.
   
   In our case, equals are based on 2 parameters, while hashCode on 3. I updated hashCode
and now it respond equals function.
   `this.name.toLowerCase()` was added, because equals method compares name with ignoreCase.
   
   ## Testing
   Manual tests
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message