dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] chickenlj closed pull request #1620: [Dubbo-1619] Fix exception stack trace during provider demo start.
Date Tue, 24 Apr 2018 07:26:59 GMT
chickenlj closed pull request #1620: [Dubbo-1619] Fix exception stack trace during provider
demo start.
URL: https://github.com/apache/incubator-dubbo/pull/1620

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/dubbo-common/src/main/java/com/alibaba/dubbo/common/Constants.java b/dubbo-common/src/main/java/com/alibaba/dubbo/common/Constants.java
index bca68aa28f..55e86d0382 100644
--- a/dubbo-common/src/main/java/com/alibaba/dubbo/common/Constants.java
+++ b/dubbo-common/src/main/java/com/alibaba/dubbo/common/Constants.java
@@ -633,6 +633,8 @@
     public static final boolean DEFAULT_HESSIAN_OVERLOAD_METHOD = false;
+    public static final String MULTICAST = "multicast";
      * private Constants(){ }
diff --git a/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ServiceConfig.java
index 853ece2eaa..c0e382bd1b 100644
--- a/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ServiceConfig.java
+++ b/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ServiceConfig.java
@@ -570,6 +570,10 @@ private String findConfigedHosts(ProtocolConfig protocolConfig, List<URL>
                 if (isInvalidLocalHost(hostToBind)) {
                     if (registryURLs != null && !registryURLs.isEmpty()) {
                         for (URL registryURL : registryURLs) {
+                            if (Constants.MULTICAST.equalsIgnoreCase(registryURL.getParameter("registry")))
+                                // skip multicast registry since we cannot connect to it
via Socket
+                                continue;
+                            }
                             try {
                                 Socket socket = new Socket();
                                 try {


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

View raw message