dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] zonghaishang commented on issue #1449: fixes #1089, make ExecutionDispatcher meet dubbo-user-book
Date Wed, 25 Apr 2018 14:12:29 GMT
zonghaishang commented on issue #1449: fixes #1089, make ExecutionDispatcher meet dubbo-user-book
URL: https://github.com/apache/incubator-dubbo/pull/1449#issuecomment-384301026
 
 
   `#1`:  Too much irrelevant merge will be inconvenient review, Here is the suggestion
to pull request:
   ```
   1. Fork's master branch does not make any changes locally
   ```
   
   `#2`:   Whenever you decide to launch a pr, do the following on the local master branch:
   ```
   1.  git clone your_fork_incubator_dubbo_repository
   2. cd your_fork_incubator_dubbo_repository
   3. git remote add incubator-dubbo https://github.com/apache/incubator-dubbo.git
   4. git fetch incubator-dubbo
   5. git rebase incubator-dubbo/master
   6. git push -f
   ```
   
   `#3`:  This time you can create a pr branch based on the latest synchronized master:
   ```
   1. git checkout -b yourself_pr_branch_name
   2. git add .
   3. git commit -m "detail comments"
   4. git push
   ```
   If a branch fork already exists locally, You can repeat the operation `#2` (step 2, 4,
5, 6) then `#3`. This avoids much of the merged information.
   
   Thanks,
   yiji
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Mime
View raw message