dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] beiwei30 commented on a change in pull request #1721: [Dubbo-1681] add test for dubbo common module
Date Thu, 03 May 2018 05:48:05 GMT
beiwei30 commented on a change in pull request #1721: [Dubbo-1681] add test for dubbo common
module
URL: https://github.com/apache/incubator-dubbo/pull/1721#discussion_r185700739
 
 

 ##########
 File path: dubbo-common/src/test/java/com/alibaba/dubbo/common/io/StreamUtilsTest.java
 ##########
 @@ -18,11 +18,12 @@
 
 import org.junit.Test;
 
+import java.io.IOException;
 import java.io.InputStream;
 import java.io.PushbackInputStream;
 
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertFalse;
+import static org.hamcrest.CoreMatchers.is;
+import static org.junit.Assert.*;
 
 Review comment:
   don't use '*'

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Mime
View raw message