dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] chickenlj commented on a change in pull request #2160: [Dubbo-2030] A basically running demo implementation for introducing dynamic configuration to Dubbo.
Date Wed, 01 Aug 2018 03:02:19 GMT
chickenlj commented on a change in pull request #2160: [Dubbo-2030] A basically running demo
implementation for introducing dynamic configuration to Dubbo.
URL: https://github.com/apache/incubator-dubbo/pull/2160#discussion_r206743177
 
 

 ##########
 File path: bom/pom.xml
 ##########
 @@ -93,6 +93,11 @@
                 <artifactId>dubbo-config-spring</artifactId>
                 <version>${project.version}</version>
             </dependency>
+            <dependency>
+                <groupId>org.apache.dubbo</groupId>
+                <artifactId>dubbo-config-dynamic</artifactId>
+                <version>${project.version}</version>
+            </dependency>
 
 Review comment:
   Good point, I will add complete this part later.
   
   Besides, this PR is just a roughly working demo implementation, it's not merge ready yet.
But it provides a convenient place for discussion, let see what other developers will say.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Mime
View raw message