dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] chickenlj commented on issue #2185: Direct return when the server goes down unnormally.
Date Mon, 13 Aug 2018 08:20:01 GMT
chickenlj commented on issue #2185: Direct return when the server goes down unnormally.
URL: https://github.com/apache/incubator-dubbo/pull/2185#issuecomment-412442820
 
 
   I am not sure if Channel keeps the status of requests (`UN_FINISH_REQUESTS_MAP`) is a good
practice. For one reason, Channel is equivalent for both client and server, but only the client
cares about the status of requests. 
   
   Maybe keep the status of requests on DefaultFuture can be better?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Mime
View raw message