dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] diecui1202 closed pull request #2262: [Dubbo-#2218] fix judgment of telnet "invoke" null #2218 team 1
Date Wed, 15 Aug 2018 05:46:53 GMT
diecui1202 closed pull request #2262: [Dubbo-#2218] fix judgment of telnet "invoke" null #2218
 team 1
URL: https://github.com/apache/incubator-dubbo/pull/2262

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/telnet/support/TelnetHandlerAdapter.java
index 580238b033..d2cb91204a 100644
--- a/dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/telnet/support/TelnetHandlerAdapter.java
+++ b/dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/telnet/support/TelnetHandlerAdapter.java
@@ -56,7 +56,11 @@ public String telnet(Channel channel, String message) throws RemotingException
                 } catch (Throwable t) {
-                    buf.append(t.getMessage());
+                    if (t instanceof NullPointerException) {
+                        buf.append("Param can't be null");
+                    }else {
+                        buf.append(t.getMessage());
+                    }
             } else {
                 buf.append("Unsupported command: ");


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

View raw message