dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cdfive (GitHub) <git...@apache.org>
Subject [GitHub] [incubator-dubbo] cdfive commented on issue #2180: Proposal for deprecated o.a.d.c.extension.Activate#before and #after
Date Sun, 09 Dec 2018 03:51:37 GMT
@diecui1202 
Hi, I found the ActivateComparator class use these two methods, and there is also a test case:

https://github.com/apache/incubator-dubbo/blob/master/dubbo-common/src/test/java/org/apache/dubbo/common/extension/support/ActivateComparatorTest.java
The test case use before and after method in filter's @Activate´╝î and the case is passed.

#1926 is confusing, since I tried the before,after in our project, found it works. 

Consider a scene: a user's custorm filter which need to after or before a given filter, as
the other filter's order are uncertain, the relative order maybe more more suitable.

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2180 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
Mime
View raw message