dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From codecov-io (GitHub) <git...@apache.org>
Subject [GitHub] [incubator-dubbo] codecov-io commented on issue #2930: Improve UT grammar and remove unnecessary braces.
Date Mon, 10 Dec 2018 03:09:21 GMT
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2930?src=pr&el=h1) Report
> Merging [#2930](https://codecov.io/gh/apache/incubator-dubbo/pull/2930?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/69901348b194c476a50665d34c600816c9273966?src=pr&el=desc)
will **increase** coverage by `0.05%`.
> The diff coverage is `58.33%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/2930/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/2930?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #2930      +/-   ##
==========================================
+ Coverage   63.76%   63.81%   +0.05%     
==========================================
  Files         578      578              
  Lines       25928    25928              
  Branches     4539     4539              
==========================================
+ Hits        16532    16546      +14     
+ Misses       7224     7207      -17     
- Partials     2172     2175       +3
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2930?src=pr&el=tree)
| Coverage Δ | |
|---|---|---|
| [...bo/rpc/cluster/support/AbstractClusterInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2930/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9BYnN0cmFjdENsdXN0ZXJJbnZva2VyLmphdmE=)
| `76.53% <58.33%> (ø)` | :arrow_up: |
| [...ng/exchange/support/header/HeartbeatTimerTask.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2930/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFydGJlYXRUaW1lclRhc2suamF2YQ==)
| `73.68% <0%> (-5.27%)` | :arrow_down: |
| [...rg/apache/dubbo/common/timer/HashedWheelTimer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2930/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGltZXIvSGFzaGVkV2hlZWxUaW1lci5qYXZh)
| `58.88% <0%> (-1.75%)` | :arrow_down: |
| [...he/dubbo/registry/multicast/MulticastRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2930/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktbXVsdGljYXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9tdWx0aWNhc3QvTXVsdGljYXN0UmVnaXN0cnkuamF2YQ==)
| `63.79% <0%> (-1.73%)` | :arrow_down: |
| [...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2930/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0R1YmJvUHJvdG9jb2wuamF2YQ==)
| `66.66% <0%> (+0.83%)` | :arrow_up: |
| [...pache/dubbo/registry/support/AbstractRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2930/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L0Fic3RyYWN0UmVnaXN0cnkuamF2YQ==)
| `81.34% <0%> (+1.11%)` | :arrow_up: |
| [...dubbo/remoting/exchange/support/DefaultFuture.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2930/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L0RlZmF1bHRGdXR1cmUuamF2YQ==)
| `69.79% <0%> (+2.01%)` | :arrow_up: |
| [...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2930/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0NhbGxiYWNrU2VydmljZUNvZGVjLmphdmE=)
| `79.41% <0%> (+2.2%)` | :arrow_up: |
| [...he/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2930/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eVNlcnZlci5qYXZh)
| `71.42% <0%> (+3.57%)` | :arrow_up: |
| [...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2930/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvQWN0aXZlTGltaXRGaWx0ZXIuamF2YQ==)
| `88.88% <0%> (+5.55%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2930/diff?src=pr&el=tree-more)
| |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2930?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2930?src=pr&el=footer).
Last update [6990134...247215f](https://codecov.io/gh/apache/incubator-dubbo/pull/2930?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2930 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
Mime
View raw message