dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From khanimteyaz (GitHub) <git...@apache.org>
Subject [GitHub] [incubator-dubbo] khanimteyaz commented on pull request #2947: enhance ConsistentHashLoadBalance ut
Date Wed, 12 Dec 2018 19:42:28 GMT
Is it ok to put assert failure message, so that in future if any one go through with UT code
or UT report it can help him on addition of code.
e.g. 
        Assert.assertEquals("Same consistent hashed call should go to same node only",counter.size()
, untouchedNodesCount);
        Assert.assertEquals("Should call only same node for one consistent hash",1, touchedNodesHitMap.size());
        Assert.assertEquals("Total call should me made to same one node",runs, touchedNodesHitMap.values().iterator().next().intValue());


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2947 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


Mime
View raw message