dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From khanimteyaz (GitHub) <git...@apache.org>
Subject [GitHub] [incubator-dubbo] khanimteyaz commented on pull request #3013: [DUBBO-2988] Unrecognized the other provider
Date Wed, 19 Dec 2018 16:06:46 GMT
Should we refactor this to a another method something like 
if (isServiceMatch(provider,service) {
  -- existing code ---
}
public static boolean isServiceMatch( ProviderModel provider,String service) {
   return StringUtils.isEmpty(service) 
              ||provider.getServiceName().equalsIgnoreCase(service)
              ||provider.getServiceName().equalsIgnoreCase(service)
              ||provider.getServiceInterfaceClass().getSimpleName().equalsIgnoreCase(service)
              ||provider.getServiceInterfaceClass().getName().equalsIgnoreCase(service)
}

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3013 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


Mime
View raw message