dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From carryxyh (GitHub) <git...@apache.org>
Subject [GitHub] [incubator-dubbo] carryxyh commented on issue #3027: Simple date format each time new object creation removed
Date Fri, 21 Dec 2018 06:00:54 GMT
> If we can move all date time format into org.apache.dubbo.rpc.filter.AccessLogFilter.LogTask,
then we can safely make the formatter static, since it is now running on a single thread.

I am planning for move FILE_DATE_FORMATTER to LogTask level (as you are suggesting, i also
beleive it will make sense) as this is created once for each log thread(which is currently
single threaded). as of now to simply intiale SimpleDateFormat once per LogTask thread instance
as it is created (as of now it is not served from thread pool, when we have thread pool can
change it accordingly) and MESSAGE_DATE_FORMATTER to RpcContext level. Would you correct me
if this approach has problem. Any guidance will be appreciated.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3027 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

View raw message