dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From khanimteyaz (GitHub) <git...@apache.org>
Subject [GitHub] [incubator-dubbo] khanimteyaz commented on pull request #3043: wrong event setting
Date Mon, 24 Dec 2018 06:51:01 GMT
Thanks for explaining this. but what I was saying is for line no 192, is 
instead of having `if (data != null && data.equals(Request.READONLY_EVENT))`  we could
simplify this by just having
`if(Request.READONLY_EVENT.equals(data))`

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3043 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


Mime
View raw message