dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From khanimteyaz (GitHub) <git...@apache.org>
Subject [GitHub] [incubator-dubbo] khanimteyaz commented on pull request #3043: wrong event setting
Date Mon, 24 Dec 2018 07:53:26 GMT
With the limited knowledege about this part (so @chickenlj  @carryxyh @beiwei30  correct me
if I am not correct). I think we should either have a default event type if noting is passed
in data(more informative way and declaring a default behaviour) or we should reject the request
if no default behaviour is spported.  It will make the easy to debug and reason about the
issue. 

If we provide some default behaviour (event type) and which is not communicated, for user
it might be confusiong (because it is not documented or communicated to them).

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3043 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


Mime
View raw message