dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From carryxyh (GitHub) <git...@apache.org>
Subject [GitHub] [incubator-dubbo] carryxyh commented on issue #3027: Simple date format each time new object creation removed
Date Wed, 26 Dec 2018 08:40:04 GMT
IMO, the log message will create and log in schedule thread.

> how in the case of writing pending log message in case of jvm shutdown

What I may understand about this sentence is not very accurate. What you mean is, how do you
write the pending information to a file at the end of the JVM? I think we can let the scheduled
thread daemon.

> Do you feel, the approach I am taking is right or would you suggest me something else
here on the implementation?

I think we should change the `logQueue` to let us create log message in another thread.
Maybe like this: `ConcurrentMap<String, Set<LogData>> logQueue`. And then, our
scheduled thread just check the queue regularly. This is my thought. After that, we can promise
our log is print in only one thread and make the SimpleDateFormat single instance.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3027 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

View raw message