dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From khanimteyaz (GitHub) <git...@apache.org>
Subject [GitHub] [incubator-dubbo] khanimteyaz commented on issue #3027: Simple date format each time new object creation removed
Date Wed, 26 Dec 2018 13:50:42 GMT
@carryxyh 

> What I may understand about this sentence is not very accurate. What you mean is, how
do you write the pending information to a file at the end of the JVM? I think we can let the
scheduled thread daemon.

I am think I was wrong on the pending log message, thanks for correcting me and helping out
here. Let the schedule thread to finish the pending task 😄 

Regarding 

> I think we should change the logQueue to let us create log message in another thread.
Maybe like this: ConcurrentMap<String, Set<LogData>> logQueue. And then, our scheduled
thread just check the queue regularly. This is my thought. After that, we can promise our
log is print in only one thread and make the SimpleDateFormat single instance.

I will make the changes accordingly.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3027 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
Mime
View raw message