dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From khanimteyaz (GitHub) <git...@apache.org>
Subject [GitHub] [incubator-dubbo] khanimteyaz commented on pull request #3083: more code review.
Date Thu, 27 Dec 2018 19:17:24 GMT
I think below one would more better from symmetry to other and better from performance point
of view (although negligible 😄 )

return OVERRIDE_PROTOCOL.equals(url.getProtocol()) ||   CONFIGURATORS_CATEGORY.equals(url.getParameter(Constants.CATEGORY_KEY,
Constants.DEFAULT_CATEGORY));

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3083 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
Mime
View raw message