dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From khanimteyaz (GitHub) <git...@apache.org>
Subject [GitHub] [incubator-dubbo] khanimteyaz commented on pull request #3083: more code review.
Date Thu, 27 Dec 2018 19:36:57 GMT
If I understood correctly then here, you are transforming urls to routes using 'toRouters'
method and if there if any of the urls got transformed to route object then adding them to
**routerChain** using `ifPresent(this::addRouters)`.

I looked at **toRouters**  code and found there it is already getting added to **routerChain**

Based on these analysis do you see is there any chance of having duplicate route information
in routerChain?

I might be thinking a loud, so please correct me.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3083 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

View raw message