dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From codecov-io (GitHub) <git...@apache.org>
Subject [GitHub] [incubator-dubbo] codecov-io commented on issue #3064: Review code of TypeDefinitionBuilder
Date Fri, 28 Dec 2018 07:15:25 GMT
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3064?src=pr&el=h1) Report
> Merging [#3064](https://codecov.io/gh/apache/incubator-dubbo/pull/3064?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/5ea4fa531f9ec5ae446d4cb1ef2417b53712bd46?src=pr&el=desc)
will **decrease** coverage by `0.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3064/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3064?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #3064      +/-   ##
============================================
- Coverage     63.43%   63.41%   -0.02%     
+ Complexity       75       71       -4     
============================================
  Files           653      653              
  Lines         28261    28248      -13     
  Branches       4820     4816       -4     
============================================
- Hits          17926    17913      -13     
- Misses         8057     8062       +5     
+ Partials       2278     2273       -5
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3064?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../metadata/definition/builder/ArrayTypeBuilder.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3064/diff?src=pr&el=tree#diff-ZHViYm8tbWV0YWRhdGEtcmVwb3J0L2R1YmJvLW1ldGFkYXRhLWRlZmluaXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21ldGFkYXRhL2RlZmluaXRpb24vYnVpbGRlci9BcnJheVR5cGVCdWlsZGVyLmphdmE=)
| `75% <100%> (-6.82%)` | `3 <0> (-1)` | |
| [...bbo/metadata/definition/TypeDefinitionBuilder.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3064/diff?src=pr&el=tree#diff-ZHViYm8tbWV0YWRhdGEtcmVwb3J0L2R1YmJvLW1ldGFkYXRhLWRlZmluaXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21ldGFkYXRhL2RlZmluaXRpb24vVHlwZURlZmluaXRpb25CdWlsZGVyLmphdmE=)
| `100% <100%> (ø)` | `9 <5> (ø)` | :arrow_down: |
| [...data/definition/builder/CollectionTypeBuilder.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3064/diff?src=pr&el=tree#diff-ZHViYm8tbWV0YWRhdGEtcmVwb3J0L2R1YmJvLW1ldGFkYXRhLWRlZmluaXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21ldGFkYXRhL2RlZmluaXRpb24vYnVpbGRlci9Db2xsZWN0aW9uVHlwZUJ1aWxkZXIuamF2YQ==)
| `50% <100%> (-6.53%)` | `4 <1> (-1)` | |
| [...o/metadata/definition/builder/EnumTypeBuilder.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3064/diff?src=pr&el=tree#diff-ZHViYm8tbWV0YWRhdGEtcmVwb3J0L2R1YmJvLW1ldGFkYXRhLWRlZmluaXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21ldGFkYXRhL2RlZmluaXRpb24vYnVpbGRlci9FbnVtVHlwZUJ1aWxkZXIuamF2YQ==)
| `75% <100%> (-2.78%)` | `4 <0> (-1)` | |
| [...bo/metadata/definition/builder/MapTypeBuilder.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3064/diff?src=pr&el=tree#diff-ZHViYm8tbWV0YWRhdGEtcmVwb3J0L2R1YmJvLW1ldGFkYXRhLWRlZmluaXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21ldGFkYXRhL2RlZmluaXRpb24vYnVpbGRlci9NYXBUeXBlQnVpbGRlci5qYXZh)
| `50% <100%> (-4.55%)` | `5 <0> (-1)` | |
| [...che/dubbo/remoting/transport/mina/MinaChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3064/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L21pbmEvTWluYUNoYW5uZWwuamF2YQ==)
| `43.42% <0%> (-10.53%)` | `0% <0%> (ø)` | |
| [...he/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3064/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eVNlcnZlci5qYXZh)
| `67.85% <0%> (-3.58%)` | `0% <0%> (ø)` | |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3064/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=)
| `58.69% <0%> (-2.18%)` | `0% <0%> (ø)` | |
| [...pache/dubbo/registry/support/AbstractRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3064/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L0Fic3RyYWN0UmVnaXN0cnkuamF2YQ==)
| `80.07% <0%> (-1.88%)` | `0% <0%> (ø)` | |
| [...he/dubbo/registry/multicast/MulticastRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3064/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktbXVsdGljYXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9tdWx0aWNhc3QvTXVsdGljYXN0UmVnaXN0cnkuamF2YQ==)
| `63.79% <0%> (-1.73%)` | `0% <0%> (ø)` | |
| ... and [9 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3064/diff?src=pr&el=tree-more)
| |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3064?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3064?src=pr&el=footer).
Last update [5ea4fa5...e9cd365](https://codecov.io/gh/apache/incubator-dubbo/pull/3064?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3064 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
Mime
View raw message