dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From codecov-io (GitHub) <git...@apache.org>
Subject [GitHub] [incubator-dubbo] codecov-io commented on issue #3101: replace hard coded values with constants and small refactor
Date Sat, 29 Dec 2018 16:20:35 GMT
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3101?src=pr&el=h1) Report
> Merging [#3101](https://codecov.io/gh/apache/incubator-dubbo/pull/3101?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/f99f0158f1206ab5cadc1dfac1b373ebee25ebbd?src=pr&el=desc)
will **decrease** coverage by `0.02%`.
> The diff coverage is `85.29%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3101/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3101?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #3101      +/-   ##
============================================
- Coverage      63.6%   63.57%   -0.03%     
  Complexity       75       75              
============================================
  Files           653      653              
  Lines         28218    28214       -4     
  Branches       4803     4800       -3     
============================================
- Hits          17947    17936      -11     
- Misses         8002     8012      +10     
+ Partials       2269     2266       -3
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3101?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...c/main/java/org/apache/dubbo/common/Constants.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3101/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vQ29uc3RhbnRzLmphdmE=)
| `92.85% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...n/java/org/apache/dubbo/config/ConsumerConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3101/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Db25zdW1lckNvbmZpZy5qYXZh)
| `92.3% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...g/apache/dubbo/config/AbstractReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3101/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BYnN0cmFjdFJlZmVyZW5jZUNvbmZpZy5qYXZh)
| `93.75% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...n/java/org/apache/dubbo/config/AbstractConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3101/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BYnN0cmFjdENvbmZpZy5qYXZh)
| `79.09% <100%> (+0.64%)` | `0 <0> (ø)` | :arrow_down: |
| [.../org/apache/dubbo/config/AbstractMethodConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3101/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BYnN0cmFjdE1ldGhvZENvbmZpZy5qYXZh)
| `94% <75%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...g/apache/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3101/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BYnN0cmFjdEludGVyZmFjZUNvbmZpZy5qYXZh)
| `75.08% <87.5%> (+0.33%)` | `0 <0> (ø)` | :arrow_down: |
| [...onfig/spring/extension/SpringExtensionFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3101/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvZXh0ZW5zaW9uL1NwcmluZ0V4dGVuc2lvbkZhY3RvcnkuamF2YQ==)
| `80.48% <0%> (-4.88%)` | `0% <0%> (ø)` | |
| [.../dubbo/remoting/transport/netty4/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3101/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2hhbm5lbC5qYXZh)
| `61.17% <0%> (-4.71%)` | `0% <0%> (ø)` | |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3101/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=)
| `60.86% <0%> (-4.35%)` | `0% <0%> (ø)` | |
| [...c/main/java/org/apache/dubbo/rpc/RpcException.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3101/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNFeGNlcHRpb24uamF2YQ==)
| `82.75% <0%> (-3.45%)` | `0% <0%> (ø)` | |
| ... and [8 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3101/diff?src=pr&el=tree-more)
| |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3101?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3101?src=pr&el=footer).
Last update [f99f015...284d282](https://codecov.io/gh/apache/incubator-dubbo/pull/3101?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3101 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
Mime
View raw message