dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From khanimteyaz (GitHub) <git...@apache.org>
Subject [GitHub] [incubator-dubbo] khanimteyaz commented on issue #3095: remove @Async from core framework.
Date Sun, 30 Dec 2018 13:42:05 GMT
This looks to fine ok to me. 

Thinking loud here (please correct me if I am wrong here). As here we are enabling dubbo consumer
to  make async call to service method, but to achieve this, service provider has to define
the stub with CompletableFuture. Here whether a consumer can make a async call depends on
whether service developer has enabled service interface with CompletableFuture or not in some

The decision of communication mode (async or async) is consumer choice. So thinking, how can
we make our provider and consumer independent or each other in this context. 

e.g. here an an analogy I am using to provide the approach
java hashmap is not synchronized but java collections come up with Collection.jave and provided
a utility method `java.util.Collections.synchronizedMap()` which actually wrap hashmap with
thread safety behavior. 

@chickenlj Do you is there something we can do now or in future?

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3095 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

View raw message