dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From biyuhao (GitHub) <git...@apache.org>
Subject [GitHub] [incubator-dubbo] biyuhao opened pull request #3009: Add dubbo-monitor-logstash
Date Tue, 18 Dec 2018 15:12:18 GMT
I'm not sure if this feature can goes to the core dubbo framework.
But we can still use this PR for code review and discussion.

## What is the purpose of the change

Add dubbo monitor extension for logstash.

## Brief changelog

Add a new module called dubbo-monitor-logstash
core feature:
- act as a client for logstash-tcp-input
- jsonline format or URL-like palintext format
- one-way or two-way SSL authentication
- auto re-connect

## Verifying this change

Please run unit test from local.

You can start with a demo here
https://github.com/biyuhao/dubbo-samples-monitor-logstash

Follow this checklist to help us incorporate your contribution quickly and easily:

- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues)
field for the change (usually before you start working on it). Trivial changes like typos
do not require a GITHUB issue. Your pull request should address just this issue, without pulling
in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config
not exist #XXX`. Each commit in the pull request should have a meaningful subject line and
body.
- [x] Write a pull request description that is detailed enough to understand what the pull
request does, how, and why.
- [x] Write necessary unit-test to verify your logic correction, more mock a little better
when cross module dependency exist. If the new feature or significant change is committed,
please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [x] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test`
to make sure unit-test and integration-test pass.
- [x] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3009 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


Mime
View raw message