dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From CrazyHZM (GitHub) <git...@apache.org>
Subject [GitHub] [incubator-dubbo] CrazyHZM opened pull request #3087: [Dubbo-1917] fix use condition properly fix #1917
Date Fri, 28 Dec 2018 04:42:24 GMT
## What is the purpose of the change
fix  #1917
I suspect that if there is an exception in the subscription to Redis, when the disconnection
is successful, we can think that the Redis connection is broken, we need to re-initiate the
subscription, and we need to get the latest data from Redis again. But in JedisPool, no connection
monitoring mechanism is provided.
The first attribute is to achieve the effect of connection monitoring.
If my idea is correct, please review this pr
## Brief changelog

XXXXX

## Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues)
field for the change (usually before you start working on it). Trivial changes like typos
do not require a GITHUB issue. Your pull request should address just this issue, without pulling
in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config
not exist #XXX`. Each commit in the pull request should have a meaningful subject line and
body.
- [x] Write a pull request description that is detailed enough to understand what the pull
request does, how, and why.
- [x] Write necessary unit-test to verify your logic correction, more mock a little better
when cross module dependency exist. If the new feature or significant change is committed,
please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test`
to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3087 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


Mime
View raw message