dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From khanimteyaz (GitHub) <git...@apache.org>
Subject [GitHub] [incubator-dubbo] khanimteyaz opened pull request #3101: replace hard coded values with constants and small refactor
Date Sat, 29 Dec 2018 14:03:10 GMT
## What is the purpose of the change

Replace existing hard coded values for dubbo-config below classes

dubbo-common/src/main/java/org/apache/dubbo/common/Constants.java
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractConfig.java
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractInterfaceConfig.java
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractMethodConfig.java
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractReferenceConfig.java
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ConsumerConfig.java
Along with hard coded value replacement have done small refactoring to use java stream and
lambda.

## Brief changelog

Hard coded value replacement of few dubbo-config java classes and small refactoring.


## Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

- [x] Make sure there is a [3100](https://github.com/apache/incubator-dubbo/issues/3100) field
for the change (usually before you start working on it). Trivial changes like typos do not
require a GITHUB issue. Your pull request should address just this issue, without pulling
in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config
not exist #XXX`. Each commit in the pull request should have a meaningful subject line and
body.
- [ ] Write a pull request description that is detailed enough to understand what the pull
request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better
when cross module dependency exist. If the new feature or significant change is committed,
please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test`
to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3101 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


Mime
View raw message