From notifications-return-12392-apmail-dubbo-notifications-archive=dubbo.apache.org@dubbo.apache.org Fri Dec 21 08:48:02 2018 Return-Path: X-Original-To: apmail-dubbo-notifications-archive@minotaur.apache.org Delivered-To: apmail-dubbo-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 128341826E for ; Fri, 21 Dec 2018 08:48:02 +0000 (UTC) Received: (qmail 26661 invoked by uid 500); 21 Dec 2018 08:48:02 -0000 Delivered-To: apmail-dubbo-notifications-archive@dubbo.apache.org Received: (qmail 26643 invoked by uid 500); 21 Dec 2018 08:48:01 -0000 Mailing-List: contact notifications-help@dubbo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@dubbo.apache.org Delivered-To: mailing list notifications@dubbo.apache.org Received: (qmail 26634 invoked by uid 99); 21 Dec 2018 08:48:01 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Dec 2018 08:48:01 +0000 Received: from gitbox.apache.org (localhost [127.0.0.1]) by gitbox.apache.org (ASF Mail Server at gitbox.apache.org) with ESMTP id 41804875D1 for ; Fri, 21 Dec 2018 08:48:01 +0000 (UTC) Content-Type: multipart/mixed; boundary="===============8172411104682480576==" MIME-Version: 1.0 Subject: [GitHub] [incubator-dubbo] CrazyHZM opened pull request #3043: wrong event setting To: notifications@dubbo.apache.org From: =?utf-8?q?CrazyHZM_=28GitHub=29?= Message-ID: Date: Fri, 21 Dec 2018 08:48:01 -0000 --===============8172411104682480576== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=utf-8 ## What is the purpose of the change Event setting is wrong when the event is READONLY_EVENT. ## Brief changelog XXXXX ## Verifying this change XXXXX Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test). - [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide). [ Full content available at: https://github.com/apache/incubator-dubbo/pull/3043 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org --===============8172411104682480576== Content-Type: text/plain; charset=us-ascii --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org For additional commands, e-mail: notifications-help@dubbo.apache.org --===============8172411104682480576==--