dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chickenlj (GitHub) <git...@apache.org>
Subject [GitHub] [incubator-dubbo] chickenlj commented on issue #3663: [Dubbo-3653] etcd as config center
Date Fri, 15 Mar 2019 09:31:38 GMT
LGTM. My review focus on EtcdDynamicConfiguration.

I checked the following by running demos locally:
* can recover listeners after reconnect
* can get notified whenever updating or deleting happens
* other parts in EtcdDynamicConfiguration looks ok

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3663 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


Mime
View raw message