dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kexianjun (GitHub) <git...@apache.org>
Subject [GitHub] [incubator-dubbo] kexianjun opened issue #3678: DefaultFuture#doReceived should call done.signalAll instead of done.signalAll
Date Sat, 16 Mar 2019 04:00:13 GMT
in the method of org.apache.dubbo.remoting.exchange.support.DefaultFuture#doReceived, I think
we should call done.signalAll() instead of done.signal() ,and it's unnecessary to check done
!= null because it's always true
```java
private void doReceived(Response res) {
        lock.lock();
        try {
            response = res;
            if (done != null) {
                done.signal();
            }
        } finally {
            lock.unlock();
        }
        if (callback != null) {
            invokeCallback(callback);
        }
    }
```

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3678 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


Mime
View raw message