dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From htynkn (GitHub) <git...@apache.org>
Subject [GitHub] [incubator-dubbo] htynkn commented on issue #3651: code rule
Date Wed, 10 Apr 2019 11:15:18 GMT
> > I agree with uniform coding rules. But I personally more prefer use tool to make
sure necessary code rule is applied to project.
> > I think we need discuss what rule we need apply, for example, I see some Override
was added. If we agree to must have Override annotation, we should add a checkstyle rule (if
rule existed)
> > Another example is allow single-line statements without braces or not, it also something
need discuss
> 
> last year ,I propose this issue ,https://github.com/apache/incubator-dubbo/issues/2553.we
discuss about the issues .I've been solving these problems.


Sure. I see 
@ralf0131 would you mind have a look? This is related to https://github.com/apache/incubator-dubbo/issues/2553


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3651 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


Mime
View raw message