dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-dubbo-samples] Moriadry edited a comment on issue #73: add dubbo-samples-consul demo
Date Tue, 30 Apr 2019 08:36:59 GMT
Moriadry edited a comment on issue #73: add dubbo-samples-consul demo
URL: https://github.com/apache/incubator-dubbo-samples/issues/73#issuecomment-487864375
 
 
   Hi Ian, it seems the sample works fine. I believe some code in ConsulRegistry.java went
wrong, they don't work correctly with the TCP check. you can get correct response because
you use the `subscribed` variable to get URL subscribed, rather than the msg from consul(not
quite sure about this).
   
   pls check this branch : https://github.com/Moriadry/incubator-dubbo/tree/feature/fordebug
with this two different version of ConsulRegistry, and debug ConsulRegistryTest.testSubscribe
locally, you will find the difference.
   
   you can debug ConsulRegistryTest.testSubscribe.java, make a breakpoint at https://github.com/apache/incubator-dubbo/blob/e2f3346d9d1dff2bf6bf3ac2802e83d46b9923c0/dubbo-registry/dubbo-registry-consul/src/main/java/org/apache/dubbo/registry/consul/ConsulRegistry.java#L135
   you will figure out we cannot get a NonEmpty HealthService list response returned. But
with http-ttl Check, we can get correct HealthService list.
   
   I believe our usage of TCP check is incorrect, we can spend more time on this to figure
it out. I'm trying to fix it. I'm on my vocation those days,  so it needs a few days.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Mime
View raw message