dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Duncan-tree-zhou (GitHub) <git...@apache.org>
Subject [GitHub] [incubator-dubbo] Duncan-tree-zhou opened pull request #3803: [Dubbo-XXX] replace hard code strings with constants in config moudule
Date Wed, 03 Apr 2019 13:34:36 GMT


## What is the purpose of the change

replace hard code strings with constants in config module.

## Brief changelog

the following hard code strings had been replaced:
- in ServiceConfig:
"revision" -> Constants.REVISION_KEY
"registry" -> Constants.REGISTRY_KEY
- in RegistryConfig:
"username" -> Constants.USERNAME_KEY
"password" -> Constants.PASSWORD_KEY
"file" -> Constants.FILE_KEY
"client" -> Constants.CLIENT_KEY
- in ReferenceConfig:
"revision" -> Constants.REVISION_KEY
"methods" -> Constants.METHODS_KEY
"client" -> Constants.CLIENT_KEY
- in ProviderConfig:
"contextpath" -> Constants.CONTEXTPATH_KEY
"status" -> Constants.STATUS_KEY
- in AbstractInterfaceConfig
"logstat" -> Constants.LOGSTAT_PROTOCOL
"local" -> Constants.LOCAL_KEY
"cluster" -> Constants.CLUSTER_KEY
"proxy" -> Constants.PROXY_KEY
"filter" -> Constants.FILE_KEY
"listener" -> Constants.LISTENER_KEY
"layer" -> Constants.LAYER_KEY

the following constant vars in Constants.java :
``` java
    public static final String STATUS_KEY = "status";
    public static final String CONTEXTPATH_KEY = "contextpath";
    public static final String LISTENER_KEY = "listener";
    public static final String LAYER_KEY = "layer";

    public static final String LOGSTAT_PROTOCOL = "logstat";
```
## Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues)
field for the change (usually before you start working on it). Trivial changes like typos
do not require a GITHUB issue. Your pull request should address just this issue, without pulling
in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config
not exist #XXX`. Each commit in the pull request should have a meaningful subject line and
body.
- [x] Write a pull request description that is detailed enough to understand what the pull
request does, how, and why.
- [x] Write necessary unit-test to verify your logic correction, more mock a little better
when cross module dependency exist. If the new feature or significant change is committed,
please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [x] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test`
to make sure unit-test and integration-test pass.
- [x] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3803 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


Mime
View raw message