dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From OrDTesters (GitHub) <git...@apache.org>
Subject [GitHub] [incubator-dubbo] OrDTesters opened pull request #3849: Use singleton RegistryProtocol in tests
Date Wed, 10 Apr 2019 23:44:48 GMT
## What is the purpose of the change

Currently some tests in RegistryProtocolTest do not use the RegistryProtocol.getRegistryProtocol()
method to get the singleton RegistryProtocol instance. These tests directly create new instances
of RegistryProtocol, which changes the singleton to point to the newly created instance. Doing
so leads to tests in test class to fail when run in certain orders. For example, running the
tests [testNotifyOverride_notmatch, testExportUrlNull, testNotifyOverride] in that exact order
leads to testNotifyOverride to fail.

The proposed change is to have every test use the RegistryProtocol.getRegistryProtocol() method
to get the same instance of RegistryProtocol.

## Brief changelog

dubbo-registry/dubbo-registry-default/src/test/java/org/apache/dubbo/registry/dubbo/RegistryProtocolTest.java


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3849 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


Mime
View raw message