dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #578: Rft : Optimize lock for zookeeper registry
Date Mon, 01 Jun 2020 07:53:29 GMT

codecov-commenter edited a comment on pull request #578:
URL: https://github.com/apache/dubbo-go/pull/578#issuecomment-636663654


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=h1) Report
   > Merging [#578](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=desc)
into [feature/dubbo-2.7.5](https://codecov.io/gh/apache/dubbo-go/commit/c024ce17b3fcd636f4f9e690bfb3a5a3a7f39c32&el=desc)
will **increase** coverage by `0.01%`.
   > The diff coverage is `52.74%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/578/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=tree)
   
   ```diff
   @@                   Coverage Diff                   @@
   ##           feature/dubbo-2.7.5     #578      +/-   ##
   =======================================================
   + Coverage                65.85%   65.87%   +0.01%     
   =======================================================
     Files                      203      203              
     Lines                    10558    10551       -7     
   =======================================================
   - Hits                      6953     6950       -3     
   + Misses                    2935     2926       -9     
   - Partials                   670      675       +5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=tree) |
Coverage Δ | |
   |---|---|---|
   | [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv)
| `69.01% <0.00%> (ø)` | |
   | [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==)
| `68.51% <0.00%> (ø)` | |
   | [registry/nacos/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3MvcmVnaXN0cnkuZ28=)
| `55.31% <0.00%> (ø)` | |
   | [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==)
| `68.05% <ø> (-0.53%)` | :arrow_down: |
   | [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv)
| `51.09% <0.00%> (ø)` | |
   | [registry/consul/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL3JlZ2lzdHJ5Lmdv)
| `42.10% <20.00%> (ø)` | |
   | [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv)
| `55.40% <55.00%> (-0.30%)` | :arrow_down: |
   | [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv)
| `70.88% <88.88%> (+3.79%)` | :arrow_up: |
   | [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=)
| `81.11% <90.00%> (ø)` | |
   | [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=)
| `37.50% <0.00%> (-25.00%)` | :arrow_down: |
   | ... and [11 more](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree-more)
| |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=footer).
Last update [b364f31...f7ea5f2](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Mime
View raw message