dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [dubbo-go] zouyx commented on a change in pull request #579: Feat: add comments for config
Date Tue, 02 Jun 2020 05:47:18 GMT

zouyx commented on a change in pull request #579:
URL: https://github.com/apache/dubbo-go/pull/579#discussion_r433633120



##########
File path: config/interfaces/config_reader.go
##########
@@ -19,7 +19,7 @@ package interfaces
 
 import "bytes"
 
-// ConfigReader
+// A ConfigReader interface is used to read config from consumer or provider

Review comment:
       ```suggestion
   // ConfigReader is used to read config from consumer or provider
   ```

##########
File path: config/consumer_config.go
##########
@@ -75,17 +75,17 @@ func (c *ConsumerConfig) UnmarshalYAML(unmarshal func(interface{}) error)
error
 	return nil
 }
 
-// Prefix ...
+// Prefix returns ConsumerConfig prefix
 func (*ConsumerConfig) Prefix() string {
 	return constant.ConsumerConfigPrefix
 }
 
-// SetConsumerConfig ...
+// SetConsumerConfig sets consumerConfig by @c
 func SetConsumerConfig(c ConsumerConfig) {
 	consumerConfig = &c
 }
 
-// ConsumerInit ...
+// ConsumerInit Load config file to init consumer config

Review comment:
       ```suggestion
   // ConsumerInit loads config file to init consumer config
   ```

##########
File path: config/provider_config.go
##########
@@ -67,17 +67,17 @@ func (c *ProviderConfig) UnmarshalYAML(unmarshal func(interface{}) error)
error
 	return nil
 }
 
-// Prefix ...
+// Prefix returns ProviderConfig prefix
 func (*ProviderConfig) Prefix() string {
 	return constant.ProviderConfigPrefix
 }
 
-// SetProviderConfig ...
+// SetProviderConfig sets provider config by @p
 func SetProviderConfig(p ProviderConfig) {
 	providerConfig = &p
 }
 
-// ProviderInit ...
+// ProviderInit load config file to init provider config

Review comment:
       ```suggestion
   // ProviderInit loads config file to init provider config
   ```

##########
File path: config/graceful_shutdown.go
##########
@@ -126,10 +126,8 @@ func destroyConsumerProtocols(consumerProtocols *gxset.HashSet) {
 	}
 }
 
-/**
- * destroy the provider's protocol.
- * if the protocol is consumer's protocol too, we will keep it.
- */
+// destroy the provider's protocol.

Review comment:
       ```suggestion
   // destroyProviderProtocols destroys the provider's protocol.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Mime
View raw message