dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [dubbo-go] Patrick0308 commented on a change in pull request #579: Feat: add comments for config
Date Tue, 02 Jun 2020 12:57:10 GMT

Patrick0308 commented on a change in pull request #579:
URL: https://github.com/apache/dubbo-go/pull/579#discussion_r433853168



##########
File path: config/config_center_config.go
##########
@@ -31,7 +31,13 @@ import (
 	"github.com/apache/dubbo-go/common/constant"
 )
 
-// ConfigCenterConfig ...
+// ConfigCenterConfig is configuration for config center
+//
+// ConfigCenter also introduced concepts of namespace and group to better manage Key-Value
pairs by group,
+// those concepts are already built-in in many professional third-party configuration centers.
+// In most cases, namespace is used to isolate different tetants, while group is used to
divid the key set from one tetant into groups.

Review comment:
       ```suggestion
   // Those configs are already built-in in many professional third-party configuration centers.
   // In most cases, namespace is used to isolate different tenants, while group is used to
divide the key set from one tenant into groups.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Mime
View raw message